Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932391Ab0HaPIs (ORCPT ); Tue, 31 Aug 2010 11:08:48 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:58125 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932363Ab0HaPIq (ORCPT ); Tue, 31 Aug 2010 11:08:46 -0400 Message-ID: <4C7D1AD6.3080005@oracle.com> Date: Tue, 31 Aug 2010 08:08:06 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Masayuki Ohtake CC: Stephen Hemminger , Sam Ravnborg , Joe Perches , LKML , ML netdev , Greg Rose , Maxime Bizon , Kristoffer Glembo , Ralf Baechle , John Linn , "David S. Miller" , MeeGo , "Wang, Qi" , "Wang, Yong Y" , Andrew , Intel OTC , "Foster, Margie" , Toshiharu Okada , Tomoya Morinaga , Takahiro Shimizu Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH References: <4C763A67.5040107@dsn.okisemi.com> <4C7D0E7A.5060309@dsn.okisemi.com> In-Reply-To: <4C7D0E7A.5060309@dsn.okisemi.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3334 Lines: 87 On 08/31/10 07:15, Masayuki Ohtake wrote: > > Hi Sam, Joe and Stephen > > Thank you for your comments. > We have modified this driver for your comment. > > --- > Gigabit Ethernet driver of Topcliff PCH > Patch created against 2.6.35 > > Topcliff PCH is the platform controller hub that is going to be used in > Intel's upcoming general embedded platform. All IO peripherals in > Topcliff PCH are actually devices sitting on AMBA bus. > Topcliff PCH has Gigabit Ethernet I/F. Using this I/F, it is able to > access system devices connected to Gigabit Ethernet. > > Signed-off-by: Masayuki Ohtake > --- > drivers/net/Kconfig | 10 + > drivers/net/Makefile | 1 + > drivers/net/pch_gbe/Makefile | 4 + > drivers/net/pch_gbe/pch_gbe.h | 683 +++++++++ > drivers/net/pch_gbe/pch_gbe_api.c | 246 ++++ > drivers/net/pch_gbe/pch_gbe_api.h | 34 + > drivers/net/pch_gbe/pch_gbe_ethtool.c | 618 ++++++++ > drivers/net/pch_gbe/pch_gbe_main.c | 2591 +++++++++++++++++++++++++++++++++ > drivers/net/pch_gbe/pch_gbe_param.c | 519 +++++++ > drivers/net/pch_gbe/pch_gbe_phy.c | 276 ++++ > drivers/net/pch_gbe/pch_gbe_phy.h | 35 + > 11 files changed, 5017 insertions(+), 0 deletions(-) > create mode 100644 drivers/net/pch_gbe/Makefile > create mode 100644 drivers/net/pch_gbe/pch_gbe.h > create mode 100644 drivers/net/pch_gbe/pch_gbe_api.c > create mode 100644 drivers/net/pch_gbe/pch_gbe_api.h > create mode 100644 drivers/net/pch_gbe/pch_gbe_ethtool.c > create mode 100644 drivers/net/pch_gbe/pch_gbe_main.c > create mode 100644 drivers/net/pch_gbe/pch_gbe_param.c > create mode 100644 drivers/net/pch_gbe/pch_gbe_phy.c > create mode 100644 drivers/net/pch_gbe/pch_gbe_phy.h > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > index 2decc59..f8102de 100644 > --- a/drivers/net/Kconfig > +++ b/drivers/net/Kconfig > @@ -2004,6 +2004,16 @@ menuconfig NETDEV_1000 > If you say N, all options in this submenu will be skipped and disabled. > > if NETDEV_1000 > +config PCH_GBE > + tristate "PCH Gigabit Ethernet" > + depends on PCI IMO it's not nice to list this driver before others that are already there. > + ---help--- > + This is an gigabit ethernet driver for Topcliff PCH. This is a gigabit You aren't going to modify this text after the product is released, are you? Might as well make it better now: > + Topcliff PCH is the platform controller hub that is going to be used Topcliff PCH is the platform controller hub that is used in Intel's general embedded platform. > + in Intel's upcoming general embedded platform. > + Topcliff PCH has Gigabit Ethernet I/F. Using this I/F, it is able to Change "I/F" to "interface". > + access system devices connected to Gigabit Ethernet. > + This driver enables Gigabit Ethernet function. > > config ACENIC > tristate "Alteon AceNIC/3Com 3C985/NetGear GA620 Gigabit support" -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/