DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=Orbog6ySMm3xnGpzs0C4riBCxceiz+xWAm6r6U6YtCdfumFgBjWG8hE+EvTR0XGBHqWe+CqShHRCX4LCmpZJJuDiCn2arTqHm7WAyCS9GrGuKIk8MBmba44fS899jg+wnn/I41X7+Ao7CBK/6i4MM6rAF0hI/mQlv4NRWoyDhJU=;
Message-ID: <755774.85376.qm@web180301.mail.gq1.yahoo.com>
Date: Tue, 31 Aug 2010 13:32:08 -0700 (PDT)
From: David Brownell <david-b@pacbell.net>
Subject: Re: [PATCH v5] gpio: Add driver for basic memory-mapped GPIO controllers
To: Andrew Morton <akpm@linux-foundation.org>,
        Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
        Mark Brown <broonie@opensource.wolfsonmicro.com>,
        David Brownell <dbrownell@users.sourceforge.net>,
        Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
In-Reply-To: <20100831175839.GA32468@oksana.dev.rtsoft.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 391
Lines: 16


> 
> +static int bgpio_dir_in(struct gpio_chip *gc, unsigned int
> gpio)
> +{
> +??? return 0;


Here -EINVAL is more correct there than 0 ...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/