Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755508Ab0HaUf1 (ORCPT ); Tue, 31 Aug 2010 16:35:27 -0400 Received: from ch-smtp03.sth.basefarm.net ([80.76.149.214]:53278 "EHLO ch-smtp03.sth.basefarm.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754073Ab0HaUfZ (ORCPT ); Tue, 31 Aug 2010 16:35:25 -0400 Message-ID: <4C7D6739.5000601@euromail.se> Date: Tue, 31 Aug 2010 22:34:01 +0200 From: Henrik Rydberg User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100820 Thunderbird/3.1.2 MIME-Version: 1.0 To: Chase Douglas CC: Jiri Kosina , Michael Poole , Tejun Heo , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6 v2] HID: magicmouse: remove axis data filtering References: <1283280068-12285-1-git-send-email-chase.douglas@canonical.com> <1283280068-12285-4-git-send-email-chase.douglas@canonical.com> In-Reply-To: <1283280068-12285-4-git-send-email-chase.douglas@canonical.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Originating-IP: 83.248.196.134 X-Scan-Result: No virus found in message 1OqXXn-0007GH-9s. X-Scan-Signature: ch-smtp03.sth.basefarm.net 1OqXXn-0007GH-9s 496153d3e16d92ceafd9d1ee0b0a621a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2246 Lines: 56 On 08/31/2010 08:41 PM, Chase Douglas wrote: > The Magic Mouse device is very precise. No driver filtering of input > data needs to be performed. > > Signed-off-by: Chase Douglas > Acked-by: Michael Poole > --- I am still not sure this is a good idea. Bandwidth from MT devices is a big deal. A statement roughly how much data comes out of mtdev (which does the filtering for type A devices) before and after this change would be reassuring. Cheers, Henrik > drivers/hid/hid-magicmouse.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c > index 98bbc53..0fe2464 100644 > --- a/drivers/hid/hid-magicmouse.c > +++ b/drivers/hid/hid-magicmouse.c > @@ -357,11 +357,11 @@ static void magicmouse_setup_input(struct input_dev *input, struct hid_device *h > __set_bit(EV_ABS, input->evbit); > > input_set_abs_params(input, ABS_MT_TRACKING_ID, 0, 15, 0, 0); > - input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0, 255, 4, 0); > - input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0, 255, 4, 0); > - input_set_abs_params(input, ABS_MT_ORIENTATION, -32, 31, 1, 0); > + input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0); > + input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0, 255, 0, 0); > + input_set_abs_params(input, ABS_MT_ORIENTATION, -32, 31, 0, 0); > input_set_abs_params(input, ABS_MT_POSITION_X, -1100, 1358, > - 4, 0); > + 0, 0); > /* Note: Touch Y position from the device is inverted relative > * to how pointer motion is reported (and relative to how USB > * HID recommends the coordinates work). This driver keeps > @@ -369,7 +369,7 @@ static void magicmouse_setup_input(struct input_dev *input, struct hid_device *h > * inverse of the reported Y. > */ > input_set_abs_params(input, ABS_MT_POSITION_Y, -1589, 2047, > - 4, 0); > + 0, 0); > } > > if (report_undeciphered) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/