Subject: Re: [RFC PATCH 4/9] mce: Add persistent events
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Borislav Petkov <bp@amd64.org>, acme@infradead.org, fweisbec@gmail.com,
        mingo@elte.hu, linux-kernel@vger.kernel.org,
        Borislav Petkov <borislav.petkov@amd.com>
In-Reply-To: <1281106636.1947.710.camel@laptop>
References: <1281104713-23141-1-git-send-email-bp@amd64.org>
	 <1281104713-23141-5-git-send-email-bp@amd64.org>
	 <1281106636.1947.710.camel@laptop>
Content-Type: text/plain; charset="ISO-8859-15"
Date: Tue, 31 Aug 2010 20:13:20 -0400
Message-ID: <1283300000.1377.863.camel@gandalf.stny.rr.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1244
Lines: 33

On Fri, 2010-08-06 at 16:57 +0200, Peter Zijlstra wrote:
> On Fri, 2010-08-06 at 16:25 +0200, Borislav Petkov wrote:
> > +static const struct file_operations perf_mce_fops = {
> > +       .llseek         = no_llseek,
> > +       .open           = mce_perf_open,
> > +       .poll           = perf_poll,
> > +       .unlocked_ioctl = perf_ioctl,
> > +       .compat_ioctl   = perf_ioctl,
> > +       .mmap           = perf_mmap,
> > +       .fasync         = perf_fasync,
> > +       .release        = perf_release,
> > +}; 
> 
> I'd rather see this part of the persistent bits live in
> kernel/perf_event.c, that way you don't need the previous patch either.
> 

This is part of what I hate about the perf design. The fact that
everything needs to be very coupled. I would like the infrastructure to
be more flexible.

If this does not work, we should have a better internal API that lets
this be done. Otherwise we will have this mce fops in core code that has
no business being there.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/