Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755334Ab0IAAgz (ORCPT ); Tue, 31 Aug 2010 20:36:55 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:42770 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496Ab0IAAgx (ORCPT ); Tue, 31 Aug 2010 20:36:53 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Wed, 1 Sep 2010 09:31:51 +0900 From: KAMEZAWA Hiroyuki To: Daisuke Nishimura Cc: linux-mm@kvack.org, "balbir@linux.vnet.ibm.com" , gthelen@google.com, m-ikeda@ds.jp.nec.com, "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "menage@google.com" , "lizf@cn.fujitsu.com" Subject: Re: [PATCH 5/5] memcg: generic file stat accounting interface Message-Id: <20100901093151.8d6cb0e8.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20100831133329.3c54b214.nishimura@mxp.nes.nec.co.jp> References: <20100825170435.15f8eb73.kamezawa.hiroyu@jp.fujitsu.com> <20100825171140.69c1661a.kamezawa.hiroyu@jp.fujitsu.com> <20100831133329.3c54b214.nishimura@mxp.nes.nec.co.jp> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.0.3 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1683 Lines: 49 On Tue, 31 Aug 2010 13:33:29 +0900 Daisuke Nishimura wrote: > On Wed, 25 Aug 2010 17:11:40 +0900 > KAMEZAWA Hiroyuki wrote: > > > From: KAMEZAWA Hiroyuki > > > > Preparing for adding new status arounf file caches.(dirty, writeback,etc..) > > Using a unified macro and more generic names. > > All counters will have the same rule for updating. > > > > Signed-off-by: KAMEZAWA Hiroyuki > > Reviewed-by: Daisuke Nishimura > > one nitpick. > > > @@ -2042,17 +2031,20 @@ static void __mem_cgroup_commit_charge(s > > static void __mem_cgroup_move_account(struct page_cgroup *pc, > > struct mem_cgroup *from, struct mem_cgroup *to, bool uncharge) > > { > > + int i; > > VM_BUG_ON(from == to); > > VM_BUG_ON(PageLRU(pc->page)); > > VM_BUG_ON(!PageCgroupLocked(pc)); > > VM_BUG_ON(!PageCgroupUsed(pc)); > > VM_BUG_ON(id_to_memcg(pc->mem_cgroup, true) != from); > > > > - if (PageCgroupFileMapped(pc)) { > > + for (i = MEM_CGROUP_FSTAT_BASE; i < MEM_CGROUP_FSTAT_END; ++i) { > > + if (!test_bit(fflag_idx(MEMCG_FSTAT_IDX(i)), &pc->flags)) > > + continue; > > /* Update mapped_file data for mem_cgroup */ > It might be better to update this comment too. > > /* Update file-stat data for mem_cgroup */ > > or something ? > Nice catch. I'll fix this. -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/