Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752517Ab0KAS1K (ORCPT ); Mon, 1 Nov 2010 14:27:10 -0400 Received: from mail3.microsoft.com ([131.107.115.214]:8041 "EHLO smtp.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746Ab0KAS1H convert rfc822-to-8bit (ORCPT ); Mon, 1 Nov 2010 14:27:07 -0400 From: Haiyang Zhang To: Greg KH CC: Hank Janssen , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "virtualization@lists.osdl.org" Subject: RE: [PATCH 03/10] staging: hv: Convert camel cased struct fields in hv.h to lower cases Thread-Topic: [PATCH 03/10] staging: hv: Convert camel cased struct fields in hv.h to lower cases Thread-Index: AQHLee2WbjO5faID10a9YXb0/O4IhpNc61eA Date: Mon, 1 Nov 2010 18:27:04 +0000 Message-ID: <1FB5E1D5CA062146B38059374562DF728BA19E86@TK5EX14MBXC128.redmond.corp.microsoft.com> References: <1288630429-12330-1-git-send-email-haiyangz@linuxonhyperv.com> <20101101174310.GA12632@suse.de> In-Reply-To: <20101101174310.GA12632@suse.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [157.54.51.72] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1286 Lines: 30 > From: Greg KH [mailto:gregkh@suse.de] > Sent: Monday, November 01, 2010 1:43 PM > Why did I get two different copies of some of these patches? Are they > different? They are the same. Initially, I sent all 10 patches out at the same time, but I only saw 5 of them in my mail box. So I re-sent the 5 missing ones. Half hour later, I found the 5 previous missing emails were not lost, and received again at a later time. > > /* The one and only */ > > -struct hv_context gHvContext = { > > - .SynICInitialized = false, > > - .HypercallPage = NULL, > > - .SignalEventParam = NULL, > > - .SignalEventBuffer = NULL, > > +struct hv_context g_hv_context = { > > What is the "g_" for? Why are you keeping the unneeded, and unwanted > hungarian notation around? Please don't do that. The "g_" was used for global variables. I also saw some other global variables with the hungarian notation. Since this notation is not related to camel case conversion, how about we remove the hungarian notations in a separate patch? Thanks, - Haiyang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/