Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754760Ab0KBBbI (ORCPT ); Mon, 1 Nov 2010 21:31:08 -0400 Received: from straum.hexapodia.org ([207.7.131.186]:36588 "EHLO straum.hexapodia.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752783Ab0KBBbG (ORCPT ); Mon, 1 Nov 2010 21:31:06 -0400 Date: Mon, 1 Nov 2010 18:31:06 -0700 From: Andy Isaacson To: Matthew Garrett Cc: srajiv@linux.vnet.ibm.com, linux-kernel@vger.kernel.org Subject: Re: suspend fails on x200 (was Re: [PATCH] tpm: Autodetect itpm devices) Message-ID: <20101102013106.GX5988@hexapodia.org> References: <1287697360-31273-1-git-send-email-mjg@redhat.com> <20101101211948.GA19250@hexapodia.org> <20101101213224.GA28746@srcf.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101101213224.GA28746@srcf.ucam.org> X-GPG-Fingerprint: 1914 0645 FD53 C18E EEEF C402 4A69 B1F3 68D2 A63F X-GPG-Key-URL: http://web.hexapodia.org/~adi/gpg.txt X-Domestic-Surveillance: money launder bomb tax evasion User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1435 Lines: 31 On Mon, Nov 01, 2010 at 09:32:24PM +0000, Matthew Garrett wrote: > On Mon, Nov 01, 2010 at 02:19:48PM -0700, Andy Isaacson wrote: > > I suspect that it would have failed previously if I'd forced the module > > to load, but since tpm_tis now loads automatically as of 2.6.37-rc1, I > > have to "rmmod tpm_tis" for suspend to work. > > Hm. That's what this patch was intended to fix. Can you check that the > tree you're using has it merged? The autoloading comes from the fix to > the pnp code to use _CID even if _HID is malformed, so now we have a pnp > device when we previously didn't. Hmmm, I am testing with straight-up .37-rc1, c8ddb2713c62. It does not include your patch. This time around, still running -rc1, I ran pm-suspend and it suspended + resumed fine. The second time I ran pm-suspend, it switched to text console and started flashing the moon LED, but hung there with the LCD backlight still on and the LED moon flashing. So, definitely something exciting going on... and not a simple suspend regression, and definitely not caused by this patch, my apologies. Subject line updated accordingly. I'll try applying "Autodetect itpm devices" and report back. -andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/