From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andy Isaacson <adi@hexapodia.org>
Subject: Re: suspend fails on x200 (was Re: [PATCH] tpm: Autodetect itpm devices)
Date: Tue, 2 Nov 2010 04:47:53 +0100
User-Agent: KMail/1.13.5 (Linux/2.6.36-rjw+; KDE/4.4.4; x86_64; ; )
Cc: Matthew Garrett <mjg59@srcf.ucam.org>, srajiv@linux.vnet.ibm.com,
        linux-kernel@vger.kernel.org
References: <1287697360-31273-1-git-send-email-mjg@redhat.com> <20101102013106.GX5988@hexapodia.org> <20101102023628.GB19250@hexapodia.org>
In-Reply-To: <20101102023628.GB19250@hexapodia.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201011020447.53273.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2016
Lines: 42

On Tuesday, November 02, 2010, Andy Isaacson wrote:
> On Mon, Nov 01, 2010 at 06:31:06PM -0700, Andy Isaacson wrote:
> > On Mon, Nov 01, 2010 at 09:32:24PM +0000, Matthew Garrett wrote:
> > > On Mon, Nov 01, 2010 at 02:19:48PM -0700, Andy Isaacson wrote:
> > > > I suspect that it would have failed previously if I'd forced the module
> > > > to load, but since tpm_tis now loads automatically as of 2.6.37-rc1, I
> > > > have to "rmmod tpm_tis" for suspend to work.
> > > 
> > > Hm. That's what this patch was intended to fix. Can you check that the 
> > > tree you're using has it merged? The autoloading comes from the fix to 
> > > the pnp code to use _CID even if _HID is malformed, so now we have a pnp 
> > > device when we previously didn't.
> > 
> > Hmmm, I am testing with straight-up .37-rc1, c8ddb2713c62.  It does not
> > include your patch.
> > 
> > This time around, still running -rc1, I ran pm-suspend and it suspended
> > + resumed fine.  The second time I ran pm-suspend, it switched to text
> > console and started flashing the moon LED, but hung there with the LCD
> > backlight still on and the LED moon flashing.
> > 
> > So, definitely something exciting going on... and not a simple
> > suspend regression, and definitely not caused by this patch, my
> > apologies.  Subject line updated accordingly.
> > 
> > I'll try applying "Autodetect itpm devices" and report back.
> 
> With your patch applied on top of -rc1, suspend + resume seems to work
> fine, and I don't have any error messages from tpm in dmesg.
> 
> Thanks, problem solved.  (Still no idea what caused that one
> hang-with-blinking-moon, but it doesn't appear to be connected.)

Please give us a pointer to the patch, there are other users experiencing this issue.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/