Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935210Ab0KBFIG (ORCPT ); Tue, 2 Nov 2010 01:08:06 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:58477 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935168Ab0KBFH7 (ORCPT ); Tue, 2 Nov 2010 01:07:59 -0400 Date: Tue, 2 Nov 2010 10:37:53 +0530 From: Balbir Singh To: Jesper Juhl Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Pavel Emelianov , Minchan Kim , Paul Menage , Li Zefan , containers@lists.linux-foundation.org Subject: Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code. Message-ID: <20101102050752.GG3769@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1472 Lines: 54 * Jesper Juhl [2010-11-01 20:40:56]: > Hi (please CC me on replies), > > > Apologies to those who receive this multiple times. I screwed up the To: > field in my original mail :-( > > > In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then > followed by memset() to zero the memory. This can be more efficiently > achieved by using kzalloc() and vzalloc(). > > > Signed-off-by: Jesper Juhl > --- > memcontrol.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 9a99cfa..90da698 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4199,14 +4199,13 @@ static struct mem_cgroup *mem_cgroup_alloc(void) > > /* Can be very big if MAX_NUMNODES is very big */ > if (size < PAGE_SIZE) > - mem = kmalloc(size, GFP_KERNEL); > + mem = kzalloc(size, GFP_KERNEL); > else > - mem = vmalloc(size); > + mem = vzalloc(size); > > if (!mem) > return NULL; > > - memset(mem, 0, size); > mem->stat = alloc_percpu(struct mem_cgroup_stat_cpu); > if (!mem->stat) { > if (size < PAGE_SIZE) > Acked-by: Balbir Singh -- Three Cheers, Balbir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/