Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751114Ab0KBJij (ORCPT ); Tue, 2 Nov 2010 05:38:39 -0400 Received: from smtpeu1.atmel.com ([195.65.72.27]:64793 "EHLO bagnes.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771Ab0KBJif convert rfc822-to-8bit (ORCPT ); Tue, 2 Nov 2010 05:38:35 -0400 Subject: Re: [PATCH 1/7] [AVR32] don't check platform_get_irq's return value against zero From: Hans-Christian Egtvedt To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, David Vrabel , Greg Kroah-Hartman , Haavard Skinnemoen In-Reply-To: <20101102091545.GQ31158@pengutronix.de> References: <1260979809-24811-1-git-send-email-u.kleine-koenig@pengutronix.de> <20101019064543.GA23839@pengutronix.de> <1288605483.2843.71.camel@hcegtvedt> <20101102091545.GQ31158@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Organization: Atmel Corporation Date: Tue, 02 Nov 2010 10:30:50 +0100 Message-ID: <1288690250.32331.41.camel@hcegtvedt> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 8BIT X-OriginalArrivalTime: 02 Nov 2010 09:30:53.0064 (UTC) FILETIME=[A4D68880:01CB7A70] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1724 Lines: 40 On Tue, 2010-11-02 at 10:15 +0100, Uwe Kleine-König wrote: > Hello Hans-Christian, > > On Mon, Nov 01, 2010 at 10:58:03AM +0100, Hans-Christian Egtvedt wrote: > > On Tue, 2010-10-19 at 08:45 +0200, Uwe Kleine-König wrote: > > > On Wed, Dec 16, 2009 at 05:10:03PM +0100, Uwe Kleine-König wrote: > > > > platform_get_irq returns -ENXIO on failure, so !int_irq was probably > > > > always true. Better use (int)int_irq <= 0. Note that a return value of > > > > zero is still handled as error even though this could mean irq0. > > > > Indeed, but external interrupts are numbered after the internal > > interrupt lines, so in practice this does not happen. At least for now > > with the AP700X series. > > > > > > This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that > > > > changed the return value of platform_get_irq from 0 to -ENXIO on error. > > > > Thanks for this fix. > > > > > > Signed-off-by: Uwe Kleine-König > > > > Cc: David Vrabel > > > > Cc: Greg Kroah-Hartman > > > > Cc: Haavard Skinnemoen > > > > Acked-by: Hans-Christian Egtvedt > I thought this to go via the avr32 tree. You "only" acked, so what tree > do you consider here? Right now there isn't any AVR32 tree, since I have yet to receive an answer to my kernel.org account request. Could you push it through Linus tree? -- Hans-Christian Egtvedt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/