Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072Ab0KBMYU (ORCPT ); Tue, 2 Nov 2010 08:24:20 -0400 Received: from zene.cmpxchg.org ([85.214.230.12]:39724 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872Ab0KBMYR (ORCPT ); Tue, 2 Nov 2010 08:24:17 -0400 Date: Tue, 2 Nov 2010 08:24:13 -0400 From: Johannes Weiner To: Jesper Juhl Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Balbir Singh , Pavel Emelianov , Minchan Kim , Paul Menage , Li Zefan , containers@lists.linux-foundation.org Subject: Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code. Message-ID: <20101102122413.GJ840@cmpxchg.org> References: <20101101200122.GH840@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1031 Lines: 26 On Mon, Nov 01, 2010 at 08:59:13PM +0100, Jesper Juhl wrote: > On Mon, 1 Nov 2010, Johannes Weiner wrote: > > > On Mon, Nov 01, 2010 at 08:40:56PM +0100, Jesper Juhl wrote: > > > In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then > > > followed by memset() to zero the memory. This can be more efficiently > > > achieved by using kzalloc() and vzalloc(). > > > > > > Signed-off-by: Jesper Juhl > > > > Looks good to me, but there is also the memset after kmalloc in > > alloc_mem_cgroup_per_zone_info(). Can you switch that over as well > > in this patch? You can pass __GFP_ZERO to kmalloc_node() for zeroing. > > Sure thing. > > Signed-off-by: Jesper Juhl Thanks. Reviewed-by: Johannes Weiner -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/