Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752857Ab0KBNqL (ORCPT ); Tue, 2 Nov 2010 09:46:11 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:44861 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751639Ab0KBNqG (ORCPT ); Tue, 2 Nov 2010 09:46:06 -0400 Date: Tue, 2 Nov 2010 09:46:13 -0400 From: Mark Brown To: Mattias Wallin Cc: Liam Girdwood , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] regulator: regulator disable supply fix Message-ID: <20101102134613.GF21476@opensource.wolfsonmicro.com> References: <1288700549-28535-1-git-send-email-mattias.wallin@stericsson.com> <20101102131952.GC21476@opensource.wolfsonmicro.com> <4CD015F6.5060507@stericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CD015F6.5060507@stericsson.com> X-Cookie: Never give an inch! User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 471 Lines: 13 On Tue, Nov 02, 2010 at 02:45:26PM +0100, Mattias Wallin wrote: > > but this does smell a bit like it ought to be in the _regulator_disable() > > call rather than the caller. > Would you prefer below solution instead? Yes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/