Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752974Ab0KBNz5 (ORCPT ); Tue, 2 Nov 2010 09:55:57 -0400 Received: from eu1sys200aog106.obsmtp.com ([207.126.144.121]:45186 "EHLO eu1sys200aog106.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752874Ab0KBNzy (ORCPT ); Tue, 2 Nov 2010 09:55:54 -0400 X-Greylist: delayed 623 seconds by postgrey-1.27 at vger.kernel.org; Tue, 02 Nov 2010 09:55:53 EDT From: Mattias Wallin To: Liam Girdwood , Mark Brown Cc: , Mattias Wallin Subject: [PATCH v2] regulator: regulator disable supply fix Date: Tue, 2 Nov 2010 14:55:34 +0100 Message-ID: <1288706135-30836-1-git-send-email-mattias.wallin@stericsson.com> X-Mailer: git-send-email 1.6.3.3 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 32 This patch fixes a disable failure when regulator supply is used. A while loop in regulator disable checks for supply pointer != NULL but the pointer is not always updated, resulting in the while loop running too many times causing a disable failure. Signed-off-by: Mattias Wallin Acked-by: Linus Walleij Acked-by: Mark Brown --- drivers/regulator/core.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index f1d10c9..c625633 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1359,6 +1359,7 @@ static int _regulator_disable(struct regulator_dev *rdev, struct regulator_dev **supply_rdev_ptr) { int ret = 0; + *supply_rdev_ptr = NULL; if (WARN(rdev->use_count <= 0, "unbalanced disables for %s\n", -- 1.6.3.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/