Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751761Ab0KBVuD (ORCPT ); Tue, 2 Nov 2010 17:50:03 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:44985 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862Ab0KBVuA (ORCPT ); Tue, 2 Nov 2010 17:50:00 -0400 MIME-Version: 1.0 In-Reply-To: <201010292358.27975.rjw@sisk.pl> References: <201010292358.27975.rjw@sisk.pl> From: Linus Torvalds Date: Tue, 2 Nov 2010 17:49:08 -0400 Message-ID: Subject: Re: [GIT PULL] One more power management fix for 2.6.37 To: "Rafael J. Wysocki" , Greg KH Cc: Alan Stern , LKML , Linux-pm mailing list Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2598 Lines: 66 On Fri, Oct 29, 2010 at 5:58 PM, Rafael J. Wysocki wrote: > > Please pull one more power management fix for 2.6.37 from: > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/suspend-2.6.git pm-fixes > > It fixes a regression in the core I/O runtime PM code. I think we have more. It may be the driver core, though. So I added GregKH to the recipients too... On resume-from-ram with basically current -git (-rc1 + four patches): ... ata1.01: configured for MWDMA2 ata1: EH complete PM: resume of devices complete after 3240.438 msecs ------------[ cut here ]------------ WARNING: at lib/kref.c:34 kref_get+0x23/0x2c() Hardware name: HP Compaq 2510p Notebook PC Modules linked in: iwlagn [last unloaded: scsi_wait_scan] Pid: 7985, comm: pm-suspend Not tainted 2.6.37-rc1-00004-geb8abb9 #11 Call Trace: [] warn_slowpath_common+0x80/0x98 [] warn_slowpath_null+0x15/0x17 [] kref_get+0x23/0x2c [] kobject_get+0x1a/0x21 [] get_device+0x14/0x1a [] dpm_resume_end+0x230/0x37c [] suspend_devices_and_enter+0x158/0x188 [] enter_state+0xcb/0xcf [] state_store+0xa7/0xc6 [] kobj_attr_store+0x17/0x19 [] sysfs_write_file+0xf2/0x12e [] vfs_write+0xb0/0x12f [] sys_write+0x45/0x6c [] system_call_fastpath+0x16/0x1b ---[ end trace af18256edd598c9c ]--- Any ideas? I incuded the "ata1:..." lines, but the timestamps are actually ... [11627.776490] ata1: EH complete [11629.384719] PM: resume of devices complete after 3240.438 msecs [11629.400284] ------------[ cut here ]------------ ... so it's a second and a half after that ata1 resume EH complete message, and a bit after it says that it's completed all device resumes. This oops is then followed by a lot of other oopses,most of which didn't get captured because the box hung afterwards. But the next oops was in kmem_cache_alloc(), so I think it's because the device refcounts were bad and had caused slab corruption when being freed too early or something. So I think the other oopses are all a result of this kref problem. Hmm? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/