DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type;
  b=Mkspj7KIwq0XlaNxssYvonIXhEsnB2NY1aky7imwAOVQhnxQb2CTXOr5ivd1YGagmPdUjW/D28534Y68iXOxxk22XkiThazDPDsrdgRjM8NrUOtfFgbuHSTWrLqIRxdn/9xGEsG4Abznnqu6/16EBFlxtnyMG1YJbJTW2bHtc6o=;
Message-ID: <956998.65651.qm@web180302.mail.gq1.yahoo.com>
Date: Tue, 2 Nov 2010 19:15:16 -0700 (PDT)
From: David Brownell <david-b@pacbell.net>
Subject: Re: [PATCH v4 08/12] gpio: add ti-ssp gpio driver
To: davinci-linux-open-source@linux.davincidsp.com,
        spi-devel-general@lists.sourceforge.net,
        broonie@opensource.wolfsonmicro.com, lrg@slimlogic.co.uk,
        grant.likely@secretlab.ca, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, rpurdie@rpsys.net,
        Cyril Chemparathy <cyril@ti.com>
In-Reply-To: <1288124308-14999-9-git-send-email-cyril@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1187
Lines: 35


--- On Tue, 10/26/10, Cyril Chemparathy <cyril@ti.com> wrote:

> From: Cyril Chemparathy <cyril@ti.com>
> Subject: [PATCH v4 08/12] gpio: add ti-ssp gpio driver

On the assumptions you've tested this *AND* will
resubmit with the previously-requested change of
removing all references to non-existent
"virtual"ness in the driver ... I'll likely
add my ack to that resubmitted version

Also, chip2gpio seems an excessively generic name;
maybe chip2_ti_ssp_gpio or somesuch?

I'd still be happier seeing this "stack" packaged
as a hardware library called by various drivers
(like GPIO, SPI, etc) rather than a core driver
that's called by other drivers.  That seems like
a better structure for various vendors' "SSP"
hardware (multifunction serial interface logic)
since most function drivers just need to poke
the registers a bit differently, and don't have
much to share with a "core driver" beyond a few
setup routines (if that).

- Dave


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/