Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752590Ab0KCFZ5 (ORCPT ); Wed, 3 Nov 2010 01:25:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42042 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751007Ab0KCFZz (ORCPT ); Wed, 3 Nov 2010 01:25:55 -0400 Message-ID: <4CD0F22F.9000503@redhat.com> Date: Wed, 03 Nov 2010 13:25:03 +0800 From: Xiaotian Feng User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Fedora/3.1.6-1.fc15 Thunderbird/3.1.6 MIME-Version: 1.0 To: Eric Dumazet CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Alexey Kuznetsov , "Pekka Savola (ipv6)" , James Morris , Hideaki YOSHIFUJI , Patrick McHardy Subject: Re: [PATCH] net dst: fix percpu_counter list corruption and poison overwritten References: <1288750265-17664-1-git-send-email-dfeng@redhat.com> <1288761773.2467.535.camel@edumazet-laptop> In-Reply-To: <1288761773.2467.535.camel@edumazet-laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1639 Lines: 40 On 11/03/2010 01:22 PM, Eric Dumazet wrote: > Le mercredi 03 novembre 2010 à 10:11 +0800, Xiaotian Feng a écrit : >> There're some percpu_counter list corruption and poison overwritten warnings >> in recent kernel, which is resulted by fc66f95c. >> >> commit fc66f95c switches to use percpu_counter, in ip6_route_net_init, kernel >> init the percpu_counter for dst entries, but, the percpu_counter is never destroyed >> in ip6_route_net_exit. So if the related data is freed by kernel, the freed percpu_counter >> is still on the list, then if we insert/remove other percpu_counter, list corruption >> resulted. Also, if the insert/remove option modifies the ->prev,->next pointer of >> the freed value, the poison overwritten is resulted then. >> >> With the following patch, the percpu_counter list corruption and poison overwritten >> warnings disappeared. >> >> Signed-off-by: Xiaotian Feng >> Cc: "David S. Miller" >> Cc: Alexey Kuznetsov >> Cc: "Pekka Savola (ipv6)" >> Cc: James Morris >> Cc: Hideaki YOSHIFUJI >> Cc: Patrick McHardy >> --- > > Good catch, thanks ! > > Any reason you didnt Cc me (the author of the patch) ? Sorry, I just used get_maintainer.pl to get the cc list... > > Acked-by: Eric Dumazet > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/