Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755726Ab0KCP0t (ORCPT ); Wed, 3 Nov 2010 11:26:49 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:61996 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755523Ab0KCP0p (ORCPT ); Wed, 3 Nov 2010 11:26:45 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=UWU0PpHeF7UpuTDwPajBF+WIqrzIEVdw+rIWxFxW2Qhd4mv1lgavUWa15MEtwGoOFG UhngaVEie1IuPJdSCuIT28gky6ipAlNCHo2cf1MxX+mE6+/SGB+exaZ1fa6SauKhG0rz 7vGQbVWLaMv7DV6aAZyOX8Ydai8nr+Rt4G38E= MIME-Version: 1.0 In-Reply-To: <20101103162042.297958c3@schatten.dmk.lab> References: <1288785873-16519-1-git-send-email-florian@mickler.org> <20101103162042.297958c3@schatten.dmk.lab> Date: Wed, 3 Nov 2010 16:26:44 +0100 Message-ID: Subject: Re: [PATCH] checkpatch.pl: fix CAST detection to not screw with parens handling From: Audun Hoem To: Florian Mickler Cc: Andy Whitcroft , linux-kernel Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 22 On 11/3/10, Florian Mickler wrote: > On Wed, 3 Nov 2010 13:04:33 +0100 > Florian Mickler wrote: > >> Casts have to be handled after the last type that is followed by an >> opening parenthesis is handled. > > That is the wrong fix. I realized now that with that patch we would > not claim anything as a CAST anymore. Better is probably to only claim > a CAST if av_pending is not set. Andy, would that work? It seems to be > alright... Do you have some tests for checkpatch? > > Testing it with the reported line and some other random samples it > seems to be alright. > Probably good enough of a test to try it on random kernel code. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/