Message-ID: <4CD1A228.5060107@caviumnetworks.com>
Date: Wed, 03 Nov 2010 10:55:52 -0700
From: David Daney <ddaney@caviumnetworks.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7
MIME-Version: 1.0
To: Greg KH <greg@kroah.com>
CC: cdhmanning@gmail.com, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/9] Add yaffs Kconfig and Makefile
References: <1288803204-3849-1-git-send-email-cdhmanning@gmail.com> <1288803204-3849-2-git-send-email-cdhmanning@gmail.com> <20101103174607.GA6777@kroah.com>
In-Reply-To: <20101103174607.GA6777@kroah.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 923
Lines: 25

On 11/03/2010 10:46 AM, Greg KH wrote:
> On Thu, Nov 04, 2010 at 05:53:16AM +1300, cdhmanning@gmail.com wrote:
>> From: Charles Manning<cdhmanning@gmail.com>
>>
>> Adding yaffs2 file system.
>>
>> Signed-off-by: Charles Manning<cdhmanning@gmail.com>
>> ---
>>   fs/yaffs2/Kconfig  |  190 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>>   fs/yaffs2/Makefile |   17 +++++
>
> Don't do this as your first patch, make it your last one.  Otherwise the
> build will break when you apply this one to the tree.
>

In Charles's defense, the changed to fs/Kconfig and fs/Makefile are not 
made until the last patch, so buildability should be preserved as-is.

Thanks,
David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/