Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932131Ab0KDB6y (ORCPT ); Wed, 3 Nov 2010 21:58:54 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:37031 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754629Ab0KDB6u convert rfc822-to-8bit (ORCPT ); Wed, 3 Nov 2010 21:58:50 -0400 Date: Wed, 03 Nov 2010 18:59:14 -0700 (PDT) Message-Id: <20101103.185914.245411332.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: dfeng@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net Subject: Re: [PATCH] net dst: fix percpu_counter list corruption and poison overwritten From: David Miller In-Reply-To: <1288761773.2467.535.camel@edumazet-laptop> References: <1288750265-17664-1-git-send-email-dfeng@redhat.com> <1288761773.2467.535.camel@edumazet-laptop> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 27 From: Eric Dumazet Date: Wed, 03 Nov 2010 06:22:53 +0100 > Le mercredi 03 novembre 2010 ? 10:11 +0800, Xiaotian Feng a ?crit : >> There're some percpu_counter list corruption and poison overwritten warnings >> in recent kernel, which is resulted by fc66f95c. >> >> commit fc66f95c switches to use percpu_counter, in ip6_route_net_init, kernel >> init the percpu_counter for dst entries, but, the percpu_counter is never destroyed >> in ip6_route_net_exit. So if the related data is freed by kernel, the freed percpu_counter >> is still on the list, then if we insert/remove other percpu_counter, list corruption >> resulted. Also, if the insert/remove option modifies the ->prev,->next pointer of >> the freed value, the poison overwritten is resulted then. >> >> With the following patch, the percpu_counter list corruption and poison overwritten >> warnings disappeared. >> >> Signed-off-by: Xiaotian Feng ... > Acked-by: Eric Dumazet Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/