Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752695Ab0KDCzF (ORCPT ); Wed, 3 Nov 2010 22:55:05 -0400 Received: from smtp-out.google.com ([74.125.121.35]:8202 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488Ab0KDCzC (ORCPT ); Wed, 3 Nov 2010 22:55:02 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; b=xV9lJpJtw0yjao8oUZuzWhv7JzrMpCFhsQ4umCGsd9Rd2c3V+MMaD+Nd97CAAU1VrU GjqVjefsVe7+Ys881SHQ== Date: Wed, 3 Nov 2010 19:54:53 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: "Figo.zhang" cc: figo zhang , lkml , "linux-mm@kvack.org" , Andrew Morton Subject: Re: Re:[PATCH v2]oom-kill: CAP_SYS_RESOURCE should get bonus In-Reply-To: <1288836733.2124.18.camel@myhost> Message-ID: References: <1288662213.10103.2.camel@localhost.localdomain> <1288827804.2725.0.camel@localhost.localdomain> <1288834737.2124.11.camel@myhost> <1288836733.2124.18.camel@myhost> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1093 Lines: 28 On Thu, 4 Nov 2010, Figo.zhang wrote: > In your new heuristic, you also get CAP_SYS_RESOURCE to protection. > see fs/proc/base.c, line 1167: > if (oom_score_adj < task->signal->oom_score_adj && > !capable(CAP_SYS_RESOURCE)) { > err = -EACCES; > goto err_sighand; > } That's unchanged from the old behavior with oom_adj. > so i want to protect some process like normal process not > CAP_SYS_RESOUCE, i set a small oom_score_adj , if new oom_score_adj is > small than now and it is not limited resource, it will not adjust, that > seems not right? > Tasks without CAP_SYS_RESOURCE cannot lower their own oom_score_adj, otherwise it can trivially kill other tasks. They can, however, increase their own oom_score_adj so the oom killer prefers to kill it first. I think you may be confused: CAP_SYS_RESOURCE override resource limits. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/