Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752370Ab0KDSvk (ORCPT ); Thu, 4 Nov 2010 14:51:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33947 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751265Ab0KDSvj (ORCPT ); Thu, 4 Nov 2010 14:51:39 -0400 Message-ID: <4CD300AC.3010708@redhat.com> Date: Thu, 04 Nov 2010 14:51:24 -0400 From: Mauro Carvalho Chehab User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Fedora/3.1.6-1.fc14 Thunderbird/3.1.6 MIME-Version: 1.0 To: Arnaud Lacombe CC: Randy Dunlap , Michal Marek , Linus Torvalds , kyle@redhat.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Linux Media Mailing List Subject: Re: REGRESSION: Re: [GIT] kconfig rc fixes References: <20101009224041.GA901@sepie.suse.cz> <4CD1E232.30406@redhat.com> <4CD22627.2000607@redhat.com> <4CD29493.5020101@redhat.com> <20101104101910.920efbed.randy.dunlap@oracle.com> <4CD2F735.2040903@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2209 Lines: 70 Em 04-11-2010 14:32, Arnaud Lacombe escreveu: > Hi, > > On Thu, Nov 4, 2010 at 2:11 PM, Mauro Carvalho Chehab > wrote: >> [...] >> Yes, but this makes things worse: it will allow compiling drivers that Kernel >> will never use, as they won't work without an I2C adapter, and the I2C adapter >> is not compiled. >> >> Worse than that: if you go into all V4L bridge drivers, that implements the I2C >> adapters and disable them, the I2C ancillary adapters will still be compiled >> (as they won't return to 'n'), but they will never ever be used... >> >> So, no, this is not a solution. >> >> What we need is to prompt the menu only if the user wants to do some manual configuration. >> Otherwise, just use the selects done by the drivers that implement the I2C bus adapters, >> and have some code to use those selected I2C devices. >> > These is an easy solution: doing as > `Documentation/kbuild/kconfig-language.txt' say it should be done: > > config MODULES > bool "modules ?" > default y > > config AUTO > bool "AUTO" > > config IVTV > tristate "IVTV" > select WM42 if AUTO > > menu "TV" > depends on !AUTO > > config WM42_USER > tristate "WM42" > select WM42 > > endmenu > > config WM42 > tristate > default n > > - Arnaud This may work, but it means that every single I2C/frontend/tuner will require two entries for each driver. This means to create and manage around 100+ new symbols. The drivers/media Kconfig files are complex enough as-is, without adding those 100+ new artificial symbols. We should work to make things simple and improve users experience, and not to create artificial complexity that will make Kconfig almost unreadable. I still think that the easiest way to solve this is to add some logic that will hide the menu if a condition doesn't happen. Something like: menu FOO prompt if BAR or menu FOO show if BAR Mauro. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/