DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        b=mIuwIwOvREBPEv1Kiu5fOeEiP6hGHeBmRoMtK2eGSGxzTCK/EMGuRI6lZ9Zilflgxc
         YixkX9D3gkNm+o1EvKSbRkaDLdKtwg5gzQVRoReHDNzoQn9h4L0DRe2QBmt4WZ8K4bxg
         VHdqYfytdoMqOCx6KUE1IIEiTz9K1SqZtklVU=
Message-ID: <4CD318F7.8050503@gmail.com>
Date: Fri, 05 Nov 2010 04:35:03 +0800
From: Li Zefan <lizf.kern@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.11) Gecko/20101006 Thunderbird/3.1.5
MIME-Version: 1.0
To: Jesper Juhl <jj@chaosbits.net>
CC: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Balbir Singh <balbir@linux.vnet.ibm.com>,
        Pavel Emelianov <xemul@openvz.org>,
        Minchan Kim <minchan.kim@gmail.com>, Paul Menage <menage@google.com>,
        Li Zefan <lizf@cn.fujitsu.com>, Johannes Weiner <hannes@cmpxchg.org>,
        Wu Fengguang <fengguang.wu@intel.com>,
        containers@lists.linux-foundation.org,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] cgroup: prefer [kv]zalloc[_node] over [kv]malloc+memset
 in memory controller code.
References: <alpine.LNX.2.00.1011042104140.15349@swampdragon.chaosbits.net>
In-Reply-To: <alpine.LNX.2.00.1011042104140.15349@swampdragon.chaosbits.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1022
Lines: 25

> In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then 
> followed by memset() to zero the memory. This can be more efficiently 
> achieved by using kzalloc() and vzalloc().
> There's also one situation where we can use kzalloc_node() - this is 
> what's new in this version of the patch.
> 
> The original patch was:
> 
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
> Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>
> Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
>
> Here's version 2. I'd appreciate it if someone could merge it, but I don't 
> know who that someone would be.
> 

Normally it's Andrew Morton.

btw, a better title is: [...] memcgroup: prefer ... over ... memset
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/