Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754550Ab0KENxt (ORCPT ); Fri, 5 Nov 2010 09:53:49 -0400 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237]:57522 "EHLO tim.rpsys.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751937Ab0KENxr (ORCPT ); Fri, 5 Nov 2010 09:53:47 -0400 X-Greylist: delayed 739 seconds by postgrey-1.27 at vger.kernel.org; Fri, 05 Nov 2010 09:53:46 EDT Subject: Re: [PATCH] leds-net5501: taints kernel, add license From: Richard Purdie To: Randy Dunlap , akpm Cc: lkml , torvalds , Alessandro Zummo In-Reply-To: <20101104102800.6b1cc210.randy.dunlap@oracle.com> References: <20101104102800.6b1cc210.randy.dunlap@oracle.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 05 Nov 2010 13:40:26 +0000 Message-ID: <1288964426.28481.15863.camel@rex> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1008 Lines: 36 On Thu, 2010-11-04 at 10:28 -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Add MODULE_LICENSE() that matches file comments so that kernel > is not tainted. > > leds_net5501: module license 'unspecified' taints kernel. > > Signed-off-by: Randy Dunlap Acked-by: Richard Purdie > --- > drivers/leds/leds-net5501.c | 2 ++ > 1 file changed, 2 insertions(+) > > Alessandro, why does this module not have a module_exit() function? > I.e., why can it not be unloaded? > > > --- lnx-2637-rc1.orig/drivers/leds/leds-net5501.c > +++ lnx-2637-rc1/drivers/leds/leds-net5501.c > @@ -92,3 +92,5 @@ unmap: > } > > arch_initcall(soekris_init); > + > +MODULE_LICENSE("GPL"); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/