Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753056Ab0KERKE (ORCPT ); Fri, 5 Nov 2010 13:10:04 -0400 Received: from relay1.sgi.com ([192.48.179.29]:49998 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752542Ab0KERKD (ORCPT ); Fri, 5 Nov 2010 13:10:03 -0400 Subject: Re: [PATCH 41/49] fs/xfs: Use vzalloc From: Alex Elder Reply-To: aelder@sgi.com To: Joe Perches Cc: Jiri Kosina , xfs-masters@oss.sgi.com, xfs@oss.sgi.com, linux-kernel@vger.kernel.org In-Reply-To: <10acc19712bf3d1e0ea68e7c16e1723922541249.1288925425.git.joe@perches.com> References: <10acc19712bf3d1e0ea68e7c16e1723922541249.1288925425.git.joe@perches.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 05 Nov 2010 12:09:45 -0500 Message-ID: <1288976985.2295.25.camel@doink> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 05 Nov 2010 17:09:46.0229 (UTC) FILETIME=[3F1F5A50:01CB7D0C] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 979 Lines: 34 On Thu, 2010-11-04 at 20:08 -0700, Joe Perches wrote: > Signed-off-by: Joe Perches > --- > fs/xfs/linux-2.6/kmem.h | 7 +------ > 1 files changed, 1 insertions(+), 6 deletions(-) > > diff --git a/fs/xfs/linux-2.6/kmem.h b/fs/xfs/linux-2.6/kmem.h > index f7c8f7a..292eff1 100644 > --- a/fs/xfs/linux-2.6/kmem.h > +++ b/fs/xfs/linux-2.6/kmem.h > @@ -61,12 +61,7 @@ extern void kmem_free(const void *); > > static inline void *kmem_zalloc_large(size_t size) > { > - void *ptr; > - > - ptr = vmalloc(size); > - if (ptr) > - memset(ptr, 0, size); > - return ptr; > + return vzalloc(size); > } > static inline void kmem_free_large(void *ptr) > { Looks good to me. Reviewed-by: Alex Elder -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/