Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754279Ab0KFOlX (ORCPT ); Sat, 6 Nov 2010 10:41:23 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:64795 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752882Ab0KFOlW (ORCPT ); Sat, 6 Nov 2010 10:41:22 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=HCYUe4YMKZQb31pi1vO+LuOQob0LTSz2Jk/HD6VCnumhqJXNsbJcoE9LSTFXPZJB1g +gGTwk2IlVfotmYKmCElPM8liKAMH5dsNP5Mai3ktFMIlb0/fMsrbSwL0XDEY41gE2SK qUY9vK/PQFrBD7+B8JdHYZqdb19XuY9QUT82E= From: Vasiliy Kulikov To: kernel-janitors@vger.kernel.org Cc: David Airlie , Dave Airlie , Thomas Hellstrom , Jakob Bornecrantz , Dan Carpenter , Jerome Glisse , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpu: drm: vmwgfx: fix information leak to userland Date: Sat, 6 Nov 2010 17:41:16 +0300 Message-Id: <1289054477-18100-1-git-send-email-segooon@gmail.com> X-Mailer: git-send-email 1.7.0.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 30 Structure drm_vmw_fence_rep is copied to userland with field "pad64" uninitialized. It leads to leaking of contents of kernel stack memory. Signed-off-by: Vasiliy Kulikov --- Compile tested. drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c index 51d9f9f..76954e3 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c @@ -691,6 +691,7 @@ int vmw_execbuf_ioctl(struct drm_device *dev, void *data, fence_rep.error = ret; fence_rep.fence_seq = (uint64_t) sequence; + fence_rep.pad64 = 0; user_fence_rep = (struct drm_vmw_fence_rep __user *) (unsigned long)arg->fence_rep; -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/