Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752995Ab0KFSxg (ORCPT ); Sat, 6 Nov 2010 14:53:36 -0400 Received: from mail-in-15.arcor-online.net ([151.189.21.55]:48407 "EHLO mail-in-15.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752144Ab0KFSxe (ORCPT ); Sat, 6 Nov 2010 14:53:34 -0400 X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-09.arcor-online.net 7B55D197BA1 Subject: [PATCH 3/3] HID: roccat: declaring meaning of pack pragma usage in kone and pyra driver From: Stefan Achatz Reply-To: erazor_de@users.sourceforge.net To: Jiri Kosina Cc: Randy Dunlap , Bruno =?ISO-8859-1?Q?Pr=E9mont?= , Stephane Chatty , Don Prince , Dmitry Torokhov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org In-Reply-To: References: <1287943025.2623.16.camel@neuromancer> <1288978962.2585.15.camel@neuromancer> Content-Type: text/plain; charset="UTF-8" Date: Sat, 06 Nov 2010 19:53:32 +0100 Message-ID: <1289069612.5166.4.camel@neuromancer> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 (2.30.3-1.fc13) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1389 Lines: 48 Using pack pragma to prevent padding bytes in binary data structures used for hardware communication. Explanation of these pragmas was requested. This patch does for kone and pyra what another patch does for koneplus. Signed-off-by: Stefan Achatz --- drivers/hid/hid-roccat-kone.h | 3 +++ drivers/hid/hid-roccat-pyra.h | 3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/hid/hid-roccat-kone.h b/drivers/hid/hid-roccat-kone.h index 130d656..cb0ed99 100644 --- a/drivers/hid/hid-roccat-kone.h +++ b/drivers/hid/hid-roccat-kone.h @@ -14,6 +14,9 @@ #include +/* + * Binary data structures for communication with hardware must have no padding. + */ #pragma pack(push) #pragma pack(1) diff --git a/drivers/hid/hid-roccat-pyra.h b/drivers/hid/hid-roccat-pyra.h index 22f80a8..31d7b3e 100644 --- a/drivers/hid/hid-roccat-pyra.h +++ b/drivers/hid/hid-roccat-pyra.h @@ -14,6 +14,9 @@ #include +/* + * Binary data structures for communication with hardware must have no padding. + */ #pragma pack(push) #pragma pack(1) -- 1.7.2.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/