Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753864Ab0KGX2Y (ORCPT ); Sun, 7 Nov 2010 18:28:24 -0500 Received: from mga14.intel.com ([143.182.124.37]:34166 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753704Ab0KGX2X (ORCPT ); Sun, 7 Nov 2010 18:28:23 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.58,311,1286175600"; d="scan'208";a="345695372" Date: Sun, 7 Nov 2010 23:08:01 +0000 From: Alan Cox To: Alexey Charkov Cc: linux-arm-kernel@lists.infradead.org, vt8500-wm8505-linux-kernel@googlegroups.com, Greg Kroah-Hartman , Ben Dooks , Kukjin Kim , Feng Tang , Tobias Klauser , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6 v2] serial: Add support for UART on VIA VT8500 and compatibles Message-ID: <20101107230801.5214f353@linux.intel.com> In-Reply-To: <1289147348-31969-2-git-send-email-alchark@gmail.com> References: <1289147348-31969-1-git-send-email-alchark@gmail.com> <1289147348-31969-2-git-send-email-alchark@gmail.com> Organization: Intel X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2283 Lines: 96 > +static void handle_rx(struct uart_port *port) > +{ > + struct tty_struct *tty = port->state->port.tty; What is your locking for this versus a hangup ? - tty can go NULL ? (use tty_port_tty_get/tty_kref_put) > +static int vt8500_set_baud_rate(struct uart_port *port, unsigned int > baud) +{ > + unsigned long div; > + > + div = vt8500_read(port, VT8500_URDIV) & ~(0x3ff); > + > + if (unlikely((baud < 900) || (baud > 921600))) > + div |= 7; > + else > + div |= (921600 / baud) - 1; > + > + while (vt8500_read(port, VT8500_URUSR) & (1 << 5)) > + ; cpu_relax() and needs a timeout ideally ? > + lcr = vt8500_read(&vt8500_port->uart, VT8500_URLCR); > + lcr &= ~((1 << 5) | (1 << 4)); > + if (termios->c_cflag & PARENB) { > + lcr |= (1 << 4); > + if (termios->c_cflag & PARODD) > + lcr |= (1 << 5); > + } > + > + /* calculate bits per char */ > + lcr &= ~(1 << 2); > + switch (termios->c_cflag & CSIZE) { > + case CS7: > + break; > + case CS8: > + default: > + lcr |= (1 << 2); > + break; If you don't support other CS values then also do termios->c_flag &=~CSIZE; termios->c_cflag |= CS8; here.. so the app knows, likewise if you don't support mark/space (CMSPAR) then clear the CMSPAR bit > + vt8500_write(&vt8500_port->uart, 0x88c, VT8500_URFCR); > + while (vt8500_read(&vt8500_port->uart, VT8500_URFCR) & 0xc) > + /* Wait for the reset to complete */; cpu_relax/timeout > +static struct console vt8500_console = { > + .name = "ttyS", ttyS is the 8250 style devices > + .dev_name = "ttyS", > + .major = 4, > + .minor = 64, These major/minors belong to an existing device - use new ones, or in fact unless they must be fixed use dynamic ones. If they need fixed ones then we probably want to assign four from the range for small ports. ); > + > + if (unlikely(ret)) > + uart_unregister_driver(&vt8500_uart_driver); > + > + printk(KERN_INFO "vt8500_serial: driver initialized\n"); The world really doesn't need to know about each driver being loaded. pr_debug() should be fine Looks pretty good. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/