Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753956Ab0KHAig (ORCPT ); Sun, 7 Nov 2010 19:38:36 -0500 Received: from one.firstfloor.org ([213.235.205.2]:35078 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752517Ab0KHAif (ORCPT ); Sun, 7 Nov 2010 19:38:35 -0500 Date: Mon, 8 Nov 2010 01:38:31 +0100 From: Andi Kleen To: Cyrill Gorcunov Cc: Andi Kleen , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Andi Kleen , x86@kernel.org Subject: Re: [PATCH] x86: fix apic.h unused but set warnings Message-ID: <20101108003831.GF17592@basil.fritz.box> References: <1289159606-17417-1-git-send-email-andi@firstfloor.org> <20101107212045.GC13175@lenovo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101107212045.GC13175@lenovo> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 574 Lines: 19 > At least the former code _didn't_ hide the details of which > part of 'long long' value we need. Would not > > u64 val; > rdmsrl(APIC_BASE_MSR + (reg >> 4), val); > return (u32)val; > > be more clear? Maybe, but I doubt it will make much difference either way. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/