Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754190Ab0KHJNL (ORCPT ); Mon, 8 Nov 2010 04:13:11 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:59369 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753593Ab0KHJNJ (ORCPT ); Mon, 8 Nov 2010 04:13:09 -0500 Date: Mon, 8 Nov 2010 10:13:02 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Marco Stornelli Cc: Linux Kernel , Tony Lindgren , linux-omap@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, Sanjeev Premi Subject: Re: [PATCH] arm: fix compilation warning during compilation Message-ID: <20101108091302.GO16938@pengutronix.de> References: <4CD51A9B.7010806@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4CD51A9B.7010806@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2071 Lines: 54 Hello, On Sat, Nov 06, 2010 at 10:06:35AM +0100, Marco Stornelli wrote: > From: Marco Stornelli > > During compilation of 2.6.36 for Beagle board, there a are a couple of warnings. This patch fix them. Please break lines for commit logs at around 76 chars and mention the exact compiler warning being fixed. > > Signed-off-by: Marco Stornelli > --- > > --- linux-2.6.36-orig/arch/arm/plat-omap/include/plat/usb.h 2010-10-20 22:30:22.000000000 +0200 > +++ linux-2.6.36/arch/arm/plat-omap/include/plat/usb.h 2010-11-01 09:44:13.000000000 +0100 > @@ -105,7 +105,7 @@ static inline void omap1_usb_init(struct > #if defined(CONFIG_ARCH_OMAP_OTG) || defined(CONFIG_ARCH_OMAP_OTG_MODULE) > void omap2_usbfs_init(struct omap_usb_config *pdata); > #else > -static inline omap2_usbfs_init(struct omap_usb_config *pdata) > +static inline void omap2_usbfs_init(struct omap_usb_config *pdata) > { > } > #endif > --- linux-2.6.36-orig/arch/arm/mach-omap2/mux.c 2010-10-20 22:30:22.000000000 +0200 > +++ linux-2.6.36/arch/arm/mach-omap2/mux.c 2010-11-01 10:21:29.000000000 +0100 > @@ -87,7 +87,7 @@ static char *omap_mux_options; > int __init omap_mux_init_gpio(int gpio, int val) > { > struct omap_mux_entry *e; > - struct omap_mux *gpio_mux; > + struct omap_mux *gpio_mux = NULL; this warning is already fixed by ca82876 (omap2: fix assorted compiler warnings). As this warning is a false positive (i.e. gpio_mux is never used uninitialized), making the line read struct omap_mux *uninitialized_var(gpio_mux); (IMHO) would have been a bit better for both, readabily and (probably) generated code. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/