DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=eb2nI+JDZRZuIRFYQI/vrgGY3EykfjQF7fwGRXyXhnyyAf0EAOQZsBa+NRuG3zFZgi
         mUMOCnAoV9DHi+Fxtwcv+rTwvrMoV8Jg/rmui+L9F9mFrXFdyexXHBUCrrg08ZtwCR6E
         Nq2VlTVIE4Xuji7aqNKzaoVOP5jnJN4YCLOg8=
MIME-Version: 1.0
In-Reply-To: <4CD51847.20306@gmail.com>
References: <4CD51847.20306@gmail.com>
Date: Mon, 8 Nov 2010 18:42:48 +0800
Message-ID: <AANLkTimAMAmdmJBELBmnZNycBv8nOwEf+b3EUCHEiF_9@mail.gmail.com>
Subject: Re: [PATCH 02/16 v2] pramfs: super block operations
From: yidong zhang <zhangyd6@gmail.com>
To: Marco Stornelli <marco.stornelli@gmail.com>
Cc: linux-kernel@vger.kernel.org, tim.bird@am.sony.com,
        akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 529
Lines: 16

hi Marco
> + ? ? ? retval = 0;
> + out:
> + ? ? ? if (retval && sbi->virt_addr) {
> + ? ? ? ? ? ? ? iounmap(sbi->virt_addr);
> + ? ? ? ? ? ? ? release_mem_region(sbi->phys_addr, initsize);
> + ? ? ? }
> +
> + ? ? ? return retval;
> +}
 Should add kfree(sbi) here in case of  failure?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/