DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=shRHOQ1/Z9+wIi+g5kZZML2V7nVSjyaYqYQeY5mVK9CxTdwe3+OxZMQoOvaerTKaJZ
         lwcb7L78IcuozW8UYKuPR4zahKM2wrJR/eFeParh4KrGaETcHdf+tLxKsRfm3vc1Dnfd
         duk3RWwAfFLVfL4GMOhso3FdHTOl5SbUe5XC4=
MIME-Version: 1.0
In-Reply-To: <AANLkTimAMAmdmJBELBmnZNycBv8nOwEf+b3EUCHEiF_9@mail.gmail.com>
References: <4CD51847.20306@gmail.com>
	<AANLkTimAMAmdmJBELBmnZNycBv8nOwEf+b3EUCHEiF_9@mail.gmail.com>
Date: Mon, 8 Nov 2010 12:54:14 +0100
Message-ID: <AANLkTimovr9n+QWzSUjMunw25wpSATfPdxtSG7RPfz9=@mail.gmail.com>
Subject: Re: [PATCH 02/16 v2] pramfs: super block operations
From: Marco Stornelli <marco.stornelli@gmail.com>
To: yidong zhang <zhangyd6@gmail.com>
Cc: linux-kernel@vger.kernel.org, tim.bird@am.sony.com,
        akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 623
Lines: 22

2010/11/8 yidong zhang <zhangyd6@gmail.com>:
> hi Marco
>> + ? ? ? retval = 0;
>> + out:
>> + ? ? ? if (retval && sbi->virt_addr) {
>> + ? ? ? ? ? ? ? iounmap(sbi->virt_addr);
>> + ? ? ? ? ? ? ? release_mem_region(sbi->phys_addr, initsize);
>> + ? ? ? }
>> +
>> + ? ? ? return retval;
>> +}
> ?Should add kfree(sbi) here in case of ?failure?
>

Yes, thank you very much.

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/