Subject: Re: [PATCH] Tracing: do export trace_set_clr_event
From: Steven Rostedt <rostedt@goodmis.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
        Yuanhan Liu <yuanhan.liu@linux.intel.com>,
        linux-kernel@vger.kernel.org, Frederic Weisbecker <fweisbec@gmail.com>,
        Ingo Molnar <mingo@redhat.com>
In-Reply-To: <20101108141420.GA12548@infradead.org>
References: <1289196312-25323-1-git-send-email-yuanhan.liu@linux.intel.com>
	 <20101108095610.GA22592@infradead.org>
	 <5b55a1$ijitko@fmsmga002.fm.intel.com>
	 <1289224934.12418.1.camel@gandalf.stny.rr.com>
	 <20101108141420.GA12548@infradead.org>
Content-Type: text/plain; charset="ISO-8859-15"
Date: Mon, 08 Nov 2010 09:23:04 -0500
Message-ID: <1289226184.12418.4.camel@gandalf.stny.rr.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1082
Lines: 28

On Mon, 2010-11-08 at 09:14 -0500, Christoph Hellwig wrote:
> On Mon, Nov 08, 2010 at 09:02:14AM -0500, Steven Rostedt wrote:
> > I like the trace=on parameter much better. If that is set we could
> > enable the tracepoints of that module at load time. I really do not want
> > to export the function that was proposed in that patch.
> 
> Yes.  Adding generic support in the module loader to turn on tracepoint
> seems like the much better long term strategy.  Even better if it allows
> turning on individual points instead of all or nothing.

I was thinking the same. How about this:

trace=1  - all tracepoints in the module is enabled
trace=0  - same as leaving it off

trace=name - a specific tracepoint is enabled, using the simple globs
that set_event allows.

trace=name1,name2,name3  - for more than one tracepoint.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/