Date: Mon, 8 Nov 2010 23:50:47 +0900
To: hch@infradead.org
Cc: nab@linux-iscsi.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, fujita.tomonori@lab.ntt.co.jp,
        michaelc@cs.wisc.edu, hch@lst.de, hare@suse.de,
        James.Bottomley@suse.de, axboe@kernel.dk, bharrosh@panasas.com
Subject: Re: [RFCv3 00/21] TCM Core and TCM_Loop patches for v2.6.37
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
In-Reply-To: <20101108143307.GA22121@infradead.org>
References: <1287441313-19703-1-git-send-email-nab@linux-iscsi.org>
	<20101108143307.GA22121@infradead.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20101108234328C.fujita.tomonori@lab.ntt.co.jp>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1253
Lines: 23

On Mon, 8 Nov 2010 09:33:07 -0500
Christoph Hellwig <hch@infradead.org> wrote:

> I promised you and James to get back to a throughout review for more
> than just the backends.  It's still in progress, but here is what I
> think is most important:

Agreed about all the comments. I complained about similar issues
publicly and privately.

btw, when I'm back to Japan, I resume to work on the ibmvscsis driver.


>  - Sort of the the namepspace for both the file names and function
>    names.  I think you reluctantly agreed to do that a while ago anyway,
>    but I think it's time to bite the bullet now.  Please agree on a
>    common prefix for both function names and modules.  I think the
>    target name in the directory structure is the best one, but I really
>    don't care too much.  The transport_ prefix used in some code is
>    really misleading, and the se_ in other isn't too helpful either.

Agreed. And as I said, we definitely need to fix the module names
before the mainline inclusion.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/