Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755432Ab0KHSMd (ORCPT ); Mon, 8 Nov 2010 13:12:33 -0500 Received: from casper.infradead.org ([85.118.1.10]:34003 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753067Ab0KHSMc convert rfc822-to-8bit (ORCPT ); Mon, 8 Nov 2010 13:12:32 -0500 Subject: Re: [PATCH 3/3] futex: add futex_q static initializer From: Peter Zijlstra To: Thomas Gleixner Cc: Darren Hart , linux-kernel@vger.kernel.org, Matt Fleming , mingo@elte.hu, eric.dumazet@gmail.com, jkacur@redhat.com, Darren Hart In-Reply-To: References: <1288216466-14309-1-git-send-email-dvhart@linux.intel.com> <1288216466-14309-4-git-send-email-dvhart@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Mon, 08 Nov 2010 19:12:31 +0100 Message-ID: <1289239951.2191.0.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 689 Lines: 17 On Mon, 2010-11-08 at 17:42 +0100, Thomas Gleixner wrote: > > +#define FUTEX_Q_INIT \ > > + { /* list gets initialized in queue_me()*/ \ > > + .task = NULL, NULL, FUTEX_KEY_INIT \ > > + , NULL, NULL, NULL, FUTEX_BITSET_MATCH_ANY } > > + > > That should be a static readonly variable with a proper C99 > initializer. Well, it doesn't need to actually be an existing variable, but yeah it should definately use C99 initializers. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/