Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754612Ab0KHUVV (ORCPT ); Mon, 8 Nov 2010 15:21:21 -0500 Received: from www.tglx.de ([62.245.132.106]:52107 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754513Ab0KHUVU (ORCPT ); Mon, 8 Nov 2010 15:21:20 -0500 Date: Mon, 8 Nov 2010 21:21:05 +0100 (CET) From: Thomas Gleixner To: Andi Kleen cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Andi Kleen , x86@kernel.org Subject: Re: [PATCH] x86: fix apic.h unused but set warnings In-Reply-To: <1289159606-17417-1-git-send-email-andi@firstfloor.org> Message-ID: References: <1289159606-17417-1-git-send-email-andi@firstfloor.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 780 Lines: 31 On Sun, 7 Nov 2010, Andi Kleen wrote: > static inline u32 native_apic_msr_read(u32 reg) > { > - u32 low, high; > + u32 low; > > if (reg == APIC_DFR) > return -1; > > - rdmsr(APIC_BASE_MSR + (reg >> 4), low, high); > + rdmsrl(APIC_BASE_MSR + (reg >> 4), low); > return low; > } > > @@ -181,12 +181,12 @@ extern void enable_x2apic(void); > extern void x2apic_icr_write(u32 low, u32 id); > static inline int x2apic_enabled(void) > { > - int msr, msr2; > + int msr; Please make this an u32 while at it. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/