Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756020Ab0KHXqC (ORCPT ); Mon, 8 Nov 2010 18:46:02 -0500 Received: from zene.cmpxchg.org ([85.214.230.12]:53357 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755890Ab0KHXqB (ORCPT ); Mon, 8 Nov 2010 18:46:01 -0500 Date: Tue, 9 Nov 2010 00:45:34 +0100 From: Johannes Weiner To: Greg Thelen Cc: Minchan Kim , Andrew Morton , Dave Young , Andrea Righi , KAMEZAWA Hiroyuki , Daisuke Nishimura , Balbir Singh , Wu Fengguang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch 4/4] memcg: use native word page statistics counters Message-ID: <20101108234533.GN23393@cmpxchg.org> References: <20101107215030.007259800@cmpxchg.org> <1288973333-7891-1-git-send-email-minchan.kim@gmail.com> <20101106010357.GD23393@cmpxchg.org> <20101107215030.007259800@cmpxchg.org> <20101107220353.964566018@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1713 Lines: 45 On Mon, Nov 08, 2010 at 03:27:26PM -0800, Greg Thelen wrote: > Johannes Weiner writes: > > --- a/include/linux/memcontrol.h > > +++ b/include/linux/memcontrol.h > > @@ -157,7 +157,7 @@ static inline void mem_cgroup_dec_page_s > > bool mem_cgroup_has_dirty_limit(void); > > bool mem_cgroup_dirty_info(unsigned long sys_available_mem, > > struct dirty_info *info); > > -s64 mem_cgroup_page_stat(enum mem_cgroup_nr_pages_item item); > > +long mem_cgroup_page_stat(enum mem_cgroup_nr_pages_item item); > > Ooops. I missed something in my review. > > mem_cgroup_page_stat() appears twice in memcontrol.h The return value > should match regardless of if CONFIG_CGROUP_MEM_RES_CTLR is set. > > I suggest integrating the following into you patch ([patch 4/4] memcg: > use native word page statistics counters): Right you are! Thanks. Hannes > --- > include/linux/memcontrol.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 4e046d6..7a3d915 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -351,7 +351,7 @@ static inline bool mem_cgroup_dirty_info(unsigned long sys_available_mem, > return false; > } > > -static inline s64 mem_cgroup_page_stat(enum mem_cgroup_nr_pages_item item) > +static inline long mem_cgroup_page_stat(enum mem_cgroup_nr_pages_item item) > { > return -ENOSYS; > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/