Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753937Ab0KJCLS (ORCPT ); Tue, 9 Nov 2010 21:11:18 -0500 Received: from mail-iw0-f174.google.com ([209.85.214.174]:44670 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751379Ab0KJCLS (ORCPT ); Tue, 9 Nov 2010 21:11:18 -0500 MIME-Version: 1.0 In-Reply-To: <1289353544.22787.49.camel@concordia> References: <1289339119.2191.92.camel@laptop> <20101109221338.GA19947@suse.de> <1289345811.10536.8.camel@concordia> <1289350360.22787.9.camel@concordia> <1289351423.22787.22.camel@concordia> <1289353544.22787.49.camel@concordia> From: Kay Sievers Date: Wed, 10 Nov 2010 03:11:01 +0100 Message-ID: Subject: Re: [RFC][PATCH] perf: sysfs type id To: michael@ellerman.id.au Cc: LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 22 On Wed, Nov 10, 2010 at 02:45, Michael Ellerman wrote: > On Wed, 2010-11-10 at 02:19 +0100, Kay Sievers wrote: >> >> The pseudo-convenience device_register/device_unregister should also >> >> not be used. >> > >> > Why are they in the tree if they shouldn't be used? >> >> Because they save one line and do improper error handling. >> They should all be converted to device_init+device_add/device_del/device_put. > > I don't see device_init(), or do you mean device_initialize()? It > returns void? http://lkml.org/lkml/2010/9/22/56 Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/