Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754627Ab0KJCbJ (ORCPT ); Tue, 9 Nov 2010 21:31:09 -0500 Received: from mail.perches.com ([173.55.12.10]:4898 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287Ab0KJCbG (ORCPT ); Tue, 9 Nov 2010 21:31:06 -0500 Subject: Re: [PATCH 1/9] drivers/gpu/drm/drm_stub.c: Use printf extension %pV From: Joe Perches To: Kristian =?ISO-8859-1?Q?H=F8gsberg?= Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org In-Reply-To: References: <4da8e82f773833e126fc5d2d5563093b784144e5.1289348757.git.joe@perches.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 09 Nov 2010 18:31:03 -0800 Message-ID: <1289356263.28590.85.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 859 Lines: 22 On Tue, 2010-11-09 at 21:16 -0500, Kristian Høgsberg wrote: > On Tue, Nov 9, 2010 at 7:35 PM, Joe Perches wrote: > > Using %pV reduces the number of printk calls and > > eliminates any possible message interleaving from > > other printk calls. > Wouldn't it be easier and more convenient to just make the %pV format > specifier just expect a format string and the va_arg list? Like this > printk(KERN_DEBUG "%pV", format, &args); > I mean, the %pV is kernel specific and we can just change how it works. No it wouldn't. gcc would now warn about a mismatch between format and arguments. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/