Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755176Ab0KJJBw (ORCPT ); Wed, 10 Nov 2010 04:01:52 -0500 Received: from mga02.intel.com ([134.134.136.20]:33973 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753494Ab0KJJBu (ORCPT ); Wed, 10 Nov 2010 04:01:50 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,177,1288594800"; d="scan'208";a="572016080" From: xiaohui.xin@intel.com To: netdev@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com, mingo@elte.hu, herbert@gondor.hengli.com.au, jdike@linux.intel.com, davem@davemloft.net Cc: Xin Xiaohui Subject: Re: [PATCH v15 00/17] Provide a zero-copy method on KVM virtio-net. Date: Wed, 10 Nov 2010 17:23:28 +0800 Message-Id: <1289381008-5484-1-git-send-email-xiaohui.xin@intel.com> X-Mailer: git-send-email 1.7.3 In-Reply-To: <20101109.091516.112581012.davem@davemloft.net> References: <20101109.091516.112581012.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1809 Lines: 61 From: Xin Xiaohui >2) The idea to key off of skb->dev in skb_release_data() is > fundamentally flawed since many actions can change skb->dev on you, > which will end up causing a leak of your external data areas. How about this one? If the destructor_arg is not a good candidate, then I have to add an apparent field in shinfo. Thanks Xiaohui diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 10ba67d..ad4636e 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -199,14 +199,15 @@ struct skb_shared_info { struct sk_buff *frag_list; struct skb_shared_hwtstamps hwtstamps; + /* Intermediate layers must ensure that destructor_arg + * remains valid until skb destructor */ + void * destructor_arg; + /* * Warning : all fields before dataref are cleared in __alloc_skb() */ atomic_t dataref; - /* Intermediate layers must ensure that destructor_arg - * remains valid until skb destructor */ - void * destructor_arg; /* must be last field, see pskb_expand_head() */ skb_frag_t frags[MAX_SKB_FRAGS]; }; diff --git a/net/core/skbuff.c b/net/core/skbuff.c index c83b421..eb040f4 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -343,6 +343,13 @@ static void skb_release_data(struct sk_buff *skb) if (skb_has_frags(skb)) skb_drop_fraglist(skb); + if (skb_shinfo(skb)->destructor_arg) { + struct skb_ext_page *ext_page = + skb_shinfo(skb)->destructor_arg; + if (ext_page->dtor) + ext_page->dtor(ext_page); + } + kfree(skb->head); } } -- 1.7.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/