Date: Wed, 10 Nov 2010 13:20:39 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Darren Hart <dvhart@linux.intel.com>
cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@elte.hu>,
        Eric Dumazet <eric.dumazet@gmail.com>, John Kacur <jkacur@redhat.com>
Subject: Re: [PATCH V2] futex: fix compiler warnings in exit_robust_list
In-Reply-To: <1288897200-13008-1-git-send-email-dvhart@linux.intel.com>
Message-ID: <alpine.LFD.2.00.1011101313280.2900@localhost6.localdomain6>
References: <20101104104912.GA27033@pengutronix.de> <1288897200-13008-1-git-send-email-dvhart@linux.intel.com>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 766
Lines: 21

On Thu, 4 Nov 2010, Darren Hart wrote:

> The following commit introduced a compiler warning:
> 
> Commit 1dcc41bb037533839753df983d31778b30b67d93
> futex: Change 3rd arg of fetch_robust_entry() to unsigned int*

This makes not really sense. That commit changed "int *pi" to
"unsigned int *pi" which did not introduce the warning by any
means. It's gcc being stupid, in fact it should have warned before
that change already.

And your patch is incomplete as it forgot to fix the same problem in
futex_compat.c

/me fixes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/