Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755897Ab0KJMvc (ORCPT ); Wed, 10 Nov 2010 07:51:32 -0500 Received: from ozlabs.org ([203.10.76.45]:55240 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755784Ab0KJMvb (ORCPT ); Wed, 10 Nov 2010 07:51:31 -0500 From: Rusty Russell To: Stephen Hemminger Subject: Re: [PATCH] virtio: fix format of sysfs driver/vendor files Date: Wed, 10 Nov 2010 23:21:25 +1030 User-Agent: KMail/1.13.5 (Linux/2.6.35-22-generic-pae; KDE/4.5.1; i686; ; ) Cc: Greg KH , virtualization@lists.osdl.org, linux-kernel@vger.kernel.org References: <20101109222029.65f3e192@nehalam> In-Reply-To: <20101109222029.65f3e192@nehalam> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201011102321.26288.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 17 On Wed, 10 Nov 2010 04:50:29 pm Stephen Hemminger wrote: > The sysfs files for virtio produce the wrong format and are missing > the required newline. The output for virtio bus vendor/device should > have the same format as the corresponding entries for PCI devices. > > Although this technically changes the ABI for sysfs, these files were > broken to start with! Agreed, and I don't think anyone currently uses them. Applied, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/