Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756439Ab0KJOzs (ORCPT ); Wed, 10 Nov 2010 09:55:48 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:32804 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756190Ab0KJOzr (ORCPT ); Wed, 10 Nov 2010 09:55:47 -0500 Date: Wed, 10 Nov 2010 09:55:11 -0500 From: Christoph Hellwig To: Ingo Molnar Cc: Pavel Machek , Dave Chinner , Linus Torvalds , Jens Axboe , dave b , Sanjoy Mahajan , Jesper Juhl , Chris Mason , Pekka Enberg , Aidar Kultayev , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Peter Zijlstra , Nick Piggin , Arjan van de Ven , Thomas Gleixner , "Ted Ts'o" , Corrado Zoccolo , Shaohua Li , Steven Barrett Subject: Re: 2.6.36 io bring the system to its knees Message-ID: <20101110145511.GA22073@infradead.org> References: <20101105014334.GF13830@dastard> <4CD696B4.6070002@kernel.dk> <20101110013255.GR2715@dastard> <20101110142037.GA1447@ucw.cz> <20101110142721.GA14496@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101110142721.GA14496@elte.hu> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 980 Lines: 19 On Wed, Nov 10, 2010 at 03:27:21PM +0100, Ingo Molnar wrote: > That is data that was freshly touched around the time the system went down, right? > > I.e. data that was probably half-modified by user-space to begin with. It's data that wasn't synced out yet, yes. Which isn't the problem per se. With ext3/4 in ordered mode, or xfs, or btrfs the file size won't be incremented until the data is written. in ext3/4 in writeback mode (or various non-journaling filesystems) however the inode size is updated, and metadagta changes are logged. Besides exposing stale data which is a security risk in multi-user systems it also means the inode looks modified (by size and timestamps), but contains other data than actually written. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/