Date: Wed, 10 Nov 2010 21:58:13 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Andrew Lutomirski <luto@mit.edu>
cc: Borislav Petkov <bp@amd64.org>, Clemens Ladisch <clemens@ladisch.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@elte.hu>,
        "H. Peter Anvin" <hpa@zytor.com>, x86 <x86@kernel.org>,
        =?ISO-8859-15?Q?J=F6rg_R=F6del?= <joerg.roedel@amd.com>
Subject: Re: [FALSE ALARM] Re: HPET (?) related hangs and breakage in
 2.6.35,36
In-Reply-To: <AANLkTimP1F=GsnEqp-koTdy4jfaxzKpetC3Suo1Yidcm@mail.gmail.com>
Message-ID: <alpine.LFD.2.00.1011102157000.2900@localhost6.localdomain6>
References: <AANLkTikA6hZDV0A30fku7VT7Z1P8OqxcsF-EK95pBdD=@mail.gmail.com> <4CD966D8.4000602@ladisch.de> <20101109153805.GB3146@kryptos.osrc.amd.com> <AANLkTi=cUGGpkgWcbX=KMxzu+E=Toy_O+LeLoAFFUAsh@mail.gmail.com> <20101109180123.GB31121@aftab>
 <AANLkTik107mFOqvxsBtBrc14RHwhkkZTOGgctxKPPNfW@mail.gmail.com> <AANLkTik1JdQRh_Gkz_240csVGp4sS0W8nzR5d9Pv1G-X@mail.gmail.com> <20101110185031.GB13539@aftab> <AANLkTimNuSJz0nXZCR2zu963VQ_Y9R8ix73+QbbUy7nt@mail.gmail.com> <alpine.LFD.2.00.1011102147580.2900@localhost6.localdomain6>
 <AANLkTimP1F=GsnEqp-koTdy4jfaxzKpetC3Suo1Yidcm@mail.gmail.com>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="-1463795968-441092936-1289422695=:2900"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2342
Lines: 53

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1463795968-441092936-1289422695=:2900
Content-Type: TEXT/PLAIN; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT

On Wed, 10 Nov 2010, Andrew Lutomirski wrote:
> On Wed, Nov 10, 2010 at 3:52 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Wed, 10 Nov 2010, Andrew Lutomirski wrote:
> >
> >> On Wed, Nov 10, 2010 at 1:50 PM, Borislav Petkov <bp@amd64.org> wrote:
> >> > On Wed, Nov 10, 2010 at 01:48:00PM -0500, Andrew Lutomirski wrote:
> >> >> > Clocksource: tsc unstable (delta = -34355296774 ns)
> >> >> > Switching: to clocksource hpet
> >> >>
> >> >> Please disregard -- this is a bug in nouveau (or drm) not hpet. ?I'll
> >> >> send a bug report to the maintainers.
> >> >
> >> > Interesting! Joerg was complaining about similar symptoms with .36 today
> >> > too.
> >>
> >> Well, there is a clocksource sort-of-bug that could cause confusion:
> >> when something totally unrelated to clocksources goes out to lunch,
> >> the clocksource watchdog decides that the clocksource is unstable and
> >> complains, steering everyone toward filing the wrong bug.
> >
> > How should the clocksource watchdog code know that something went to
> > lunch? The fact that we need to monitor TSC at all is horrible enough,
> > adding further heuristics to detect extended lunch breaks would be
> > just a PITA.
> 
> Could the clocksource watchdog detect when it gets woken up (i.e. when
> the hardware timer fires) instead of when it gets scheduled?  It is
> internal to the timing code, after all...
> 
> Alternatively, maybe the watchdog could just compare the TSC timestamp
> to the current value according to some other clock (PIT?  whatever
> clockevent is in use?) instead of just using the time passed into the
> delayed work in the first place.

It compares to some other clock. i.e. HPET in your case, but the
extended lunch break was larger than the HPET wrap around time :(

Thanks,

	tglx
---1463795968-441092936-1289422695=:2900--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/