Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757413Ab0KJXB7 (ORCPT ); Wed, 10 Nov 2010 18:01:59 -0500 Received: from mail-ww0-f44.google.com ([74.125.82.44]:40669 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757166Ab0KJXB6 convert rfc822-to-8bit (ORCPT ); Wed, 10 Nov 2010 18:01:58 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=Mop4MDRLZV0ThmK03Rb0v9HCjX9UeFBZNltuitxGxkcgNExKkYszHUi103hqcOzp1u 5wzhx8fatKJpYTvVt74aBXLl6AZc5Za35Mz5Dkx6K6QzqMtD4qC+ByxinHrunyvbyabY H6nvvn+4xEFXg6tcQRulqXKgj7rcHvSURT4uo= MIME-Version: 1.0 In-Reply-To: References: <1289427037.9605.3.camel@nisroch> <1289428526.9605.9.camel@nisroch> From: Andrew Lutomirski Date: Wed, 10 Nov 2010 18:01:36 -0500 X-Google-Sender-Auth: LXvQyu8w6CN8WJ5m_cXEM0dZgrs Message-ID: Subject: Re: [PATCH 2/2] nouveau: Acknowledge HPD irq in handler, not bottom half To: Maarten Maathuis Cc: bskeggs@redhat.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2195 Lines: 45 On Wed, Nov 10, 2010 at 5:55 PM, Maarten Maathuis wrote: > On Wed, Nov 10, 2010 at 11:51 PM, Andrew Lutomirski wrote: >> On Wed, Nov 10, 2010 at 5:35 PM, Ben Skeggs wrote: >>> On Wed, 2010-11-10 at 17:25 -0500, Andrew Lutomirski wrote: >>>> On Wed, Nov 10, 2010 at 5:10 PM, Ben Skeggs wrote: >>>> > On Wed, 2010-11-10 at 16:32 -0500, Andy Lutomirski wrote: >>>> >> The old code generated an interrupt storm bad enough to completely >>>> >> take down my system. >>>> >> >>>> >> This only fixes the bits that are defined nouveau_regs.h. ?Newer hardware >>>> >> uses another register that isn't described, and I don't have that hardware >>>> >> to test. >>>> > Thanks for looking at this. ?I'll take a closer look at the problem >>>> > today and see what I can come up with too, that'll work with the newer >>>> > hardware too. >>>> >>>> It should be as simple as adding an hpd1 field to the hpd_state and >>>> making exactly the same change. ?(It would be nice to put the register >>>> definitions into nouveau_regs.h as well -- I didn't really want to >>>> muck around with a bunch of magic numbers that I can't test.) >>> Yes, it is. ?I can confirm the problem on another card, but it doesn't >>> actually cause any crashes here. ?If you can rework the patch to support >>> the newer chips too, that'd be great. >>> >>> As for magic numbers, the register names for those regs are wrong >>> anyway. ?The joy of reverse-engineering the support. ?It doesn't really >>> matter if you want to stick to them or go back to "magic" numbers. >> >> That explains why INTR and CTRL seemed backwards :) ?I'll leave the >> magic numbers for the 0xe07? stuff. > > Perhaps remove the bad definitions from the reg file, or rename them > to UNKsomething? Well, they're known. One is hotplug detect enable (unless the code is wrong) and the other is hotplug interrupt status. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/