Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757499Ab0KJXkp (ORCPT ); Wed, 10 Nov 2010 18:40:45 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:18981 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757417Ab0KJXko (ORCPT ); Wed, 10 Nov 2010 18:40:44 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6163"; a="61504475" Date: Wed, 10 Nov 2010 15:40:42 -0800 From: David Brown To: Alan Stern Cc: tlinder , USB list , David Brownell , Greg Kroah-Hartman , Michal Nazarewicz , Andrew Morton , Kernel development list Subject: Re: [RFC/PATCH 1/2] Add usb_endpoint_descriptor to be part of the struct usb_ep Message-ID: <20101110234042.GA25770@huya.qualcomm.com> References: <1286092800-29107-1-git-send-email-tlinder@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1497 Lines: 36 On Sun, Oct 03, 2010 at 12:35:07PM -0400, Alan Stern wrote: > > Signed-off-by: Tatyana Linder > ... > > > diff --git a/drivers/usb/gadget/file_storage.c b/drivers/usb/gadget/file_storage.c > > index a857b7a..6264fba 100644 > > --- a/drivers/usb/gadget/file_storage.c > > +++ b/drivers/usb/gadget/file_storage.c > > @@ -3,6 +3,7 @@ > > * > > * Copyright (C) 2003-2008 Alan Stern > > * All rights reserved. > > + * Copyright (C) 2010 Code Aurora Forum. All rights reserved. > > * > > * Redistribution and use in source and binary forms, with or without > > * modification, are permitted provided that the following conditions > > Speaking for myself only, I don't think people should add their own > copyright notices in files to which they have not made substantial > changes. A little code motion and a small API adjustment don't seem > like large enough changes to justify this. Some of the other files in > this patch have even smaller changes! BTW, we agree on this. People aren't supposed to be putting these copyrights in, but they've gotten used to it up until now. Tatyana, please be careful to not insert a Code Aurora Forum copyright unless you change a significant portion of the file. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/