Message-ID: <001a01cb813f$6fc49cb0$66f8800a@maildom.okisemi.com>
From: "Toshiharu Okada" <toshiharu-linux@dsn.okisemi.com>
To: =?UTF-8?Q?Micha=C5=82_Nazarewicz?= <m.nazarewicz@samsung.com>,
        "Andy Isaacson" <adi@hexapodia.org>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
        "LKML" <linux-kernel@vger.kernel.org>,
        "linux-usb" <linux-usb@vger.kernel.org>,
        "Wang, Qi" <qi.wang@intel.com>, "Wang, Yong Y" <yong.y.wang@intel.com>,
        "Andrew" <andrew.chih.howe.khor@intel.com>,
        "Intel OTC" <joel.clark@intel.com>,
        "Foster, Margie" <margie.foster@intel.com>,
        "Ewe, Kok Howg" <kok.howg.ewe@intel.com>
References: <4CC55AD9.6020800@dsn.okisemi.com> <20101103183750.GA23043@hexapodia.org> <op.vlum8dzo7p4s8u@pikus> <001601cb7fca$918dc5e0$66f8800a@maildom.okisemi.com> <op.vlyfn8qo7p4s8u@pikus>
Subject: Re: [PATCH v7] USB device driver of Topcliff PCH
Date: Thu, 11 Nov 2010 10:06:21 +0900
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 928
Lines: 36

Hi Michal

Thank you for your comment.
I will modify.

Best regards
Toshiharu Okada (OKI SEMICONDUCTOR)
----- Original Message ----- 
Date: Wed, 10 Nov 2010 13:29:58 +0100
From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
>
> In that case, make it:
>
> if (list_empty(&ep->queue)) {
> if (halt) { /* halt or clear halt */
> if (ep->num == PCH_UDC_EP0)
> ep->dev->stall = 1;
> pch_udc_ep_set_stall(ep);
> pch_udc_enable_ep_interrupts(ep->dev, PCH_UDC_EPINT(ep->in, ep->num));
> } else {
> pch_udc_ep_clear_stall(ep);
> }
> ret = 0;
> } else {
> dev_dbg(&dev->pdev->dev, "%s: list not empty", __func__);
> ret = -EAGAIN;
> }
>
> Ie. no need to put "ret = 0;" twice in the code.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/