Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932398Ab0KKEV5 (ORCPT ); Wed, 10 Nov 2010 23:21:57 -0500 Received: from tundra.namei.org ([65.99.196.166]:50807 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932310Ab0KKEV5 (ORCPT ); Wed, 10 Nov 2010 23:21:57 -0500 Date: Thu, 11 Nov 2010 15:19:10 +1100 (EST) From: James Morris To: Andrew Morton cc: Dan Rosenberg , linux-kernel@vger.kernel.org, Linus Torvalds , Ingo Molnar , kees.cook@canonical.com, security@kernel.org Subject: Re: [PATCH v3] Restrict unprivileged access to kernel syslog In-Reply-To: <20101110154956.83a3f84d.akpm@linux-foundation.org> Message-ID: References: <1289431735.3847.9.camel@dan> <20101110154956.83a3f84d.akpm@linux-foundation.org> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 638 Lines: 24 On Wed, 10 Nov 2010, Andrew Morton wrote: > > +#ifdef CONFIG_SECURITY_DMESG_RESTRICT > > +int dmesg_restrict = 1; > > +#else > > +int dmesg_restrict; > > +#endif > > You might be able to make this an int type and do > > int dmesg_restrict = CONFIG_SECURITY_DMESG_RESTRICT; This is cleaner, so if resending the patch, I'd prefer this version. - James -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/