Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757679Ab0KKGYf (ORCPT ); Thu, 11 Nov 2010 01:24:35 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:46301 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757491Ab0KKGYe (ORCPT ); Thu, 11 Nov 2010 01:24:34 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6163"; a="61548867" From: "Tanya Brokhman" To: , "'David Brownell'" Cc: "'Sarah Sharp'" , , "'Greg Kroah-Hartman'" , "'Michal Nazarewicz'" , "'Randy Dunlap'" , "'Laurent Pinchart'" , "'Kyungmin Park'" , "'Robert Lukassen'" , "'Matthew Wilcox'" , "'Fabien Chouteau'" , "'Tejun Heo'" , References: <1286092937-29191-1-git-send-email-tlinder@codeaurora.org> <20101004072602.GB2256@xanatos> <0daac081a669f0cc8e024644f223c0c2.squirrel@www.codeaurora.org> <20101005181126.GB7383@xanatos> <207c0a821ef60e21a605f0b45c2d3777.squirrel@www.codeaurora.org> <1286766418.2008.230.camel@helium> In-Reply-To: Subject: RE: [RFC/PATCH 2/2 RESEND] usb:gadget: Add SuperSpeed support to the Gadget Framework Date: Thu, 11 Nov 2010 08:27:12 +0200 Message-ID: <002001cb8169$7cef7c50$76ce74f0$@org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Actp7lPYowIBiuxnSNG4wFCQnPB2OwXexW7w Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2304 Lines: 58 Resending since not everyone received my reply -----Original Message----- From: Brokhman Tatyana [mailto:tlinder@codeaurora.org] Sent: Tuesday, October 12, 2010 11:18 AM To: David Brownell Cc: tlinder@codeaurora.org; Sarah Sharp; linux-usb@vger.kernel.org; Greg Kroah-Hartman; Michal Nazarewicz; Randy Dunlap; Laurent Pinchart; Kyungmin Park; Robert Lukassen; Matthew Wilcox; Fabien Chouteau; Tejun Heo; linux-kernel@vger.kernel.org Subject: Re: [RFC/PATCH 2/2] usb:gadget: Add SuperSpeed support to the Gadget Framework > >> > Ok. I suppose whatever gadget application is being used can reset >> these >> > values later? So that if you had a gadget webcam, it could set the >> > wMaxPacketSize to the frame size or whatever it needed? > > Yes ... in fact, every altsetting or configuration may need to set up > each endpoint differently ... that's why ep_enable() passes full > endpoint configs (as descriptors), so they can more easily be changed. > > If the notion is that there are values that may need to get passed from > silicon to driver, I'd like to see that done explicitly, with drivers > updating descriptors, instead of doing anything by back-door routes > that make UDC drivers making hidden updates. > > - Dave This implementation creates default SuperSpeed descriptors with default values. It is used to spare drivers that don't want to fully exploit SuperSpeed functionality from handling SupperSpeed descriptors and still be able to operate in a SupperSpeed mode. Please note that the gadget driver can still provide SuperSpeed descriptors with correct (and not default values) if it wishes to. I hope I understood your comment correctly. Please let me know if this is not the case. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/