Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756164Ab0KKT0d (ORCPT ); Thu, 11 Nov 2010 14:26:33 -0500 Received: from kroah.org ([198.145.64.141]:56021 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753956Ab0KKT0b (ORCPT ); Thu, 11 Nov 2010 14:26:31 -0500 Date: Thu, 11 Nov 2010 11:11:10 -0800 From: Greg KH To: Luben Tuikov , linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH take 2] [USB] Use normalized sense when emulating autosense Message-ID: <20101111191110.GA12308@kroah.com> References: <20101111174322.GB20296@one-eyed-alien.net> <673670.8195.qm@web31801.mail.mud.yahoo.com> <20101111184946.GC20296@one-eyed-alien.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101111184946.GC20296@one-eyed-alien.net> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 920 Lines: 22 On Thu, Nov 11, 2010 at 10:49:46AM -0800, Matthew Dharm wrote: > On Thu, Nov 11, 2010 at 10:27:11AM -0800, Luben Tuikov wrote: > > The patch uses SCSI functions to abstract the sense information irrespective of the type of format of sense data. > > Looks reasonable. The underlying SCSI functions seem to all have the tests > to distinguish between sense format types. Let's just hope there are no > devices out there which can confuse those tests, or we'll be buried in > regressions. > > ACKed-by: Matthew Dharm Luben, can you resend me the original patch with Matthew's ack on it? I no longer have it in my mboxes. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/