Date: Thu, 11 Nov 2010 21:12:59 +0100
From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Andi Kleen <andi@firstfloor.org>,
        Corey Ashford <cjashfor@linux.vnet.ibm.com>,
        Andi Kleen <ak@linux.intel.com>, linux-kernel@vger.kernel.org,
        fweisbec@gmail.com, mingo@elte.hu, acme@redhat.com, eranian@google.com
Subject: Re: [PATCH 2/3] perf: Add support for extra parameters for raw
 events
Message-ID: <20101111201259.GL18718@basil.fritz.box>
References: <1289492117-18066-1-git-send-email-andi@firstfloor.org>
 <1289492117-18066-2-git-send-email-andi@firstfloor.org>
 <4CDC2DDD.50508@linux.vnet.ibm.com>
 <4CDC3845.4030104@linux.intel.com>
 <4CDC4628.8020109@linux.vnet.ibm.com>
 <20101111194936.GJ18718@basil.fritz.box>
 <1289505587.2084.193.camel@laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1289505587.2084.193.camel@laptop>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1075
Lines: 31

On Thu, Nov 11, 2010 at 08:59:47PM +0100, Peter Zijlstra wrote:
> On Thu, 2010-11-11 at 20:49 +0100, Andi Kleen wrote:
> > > I think it would have parsed OK, but it is a confusing syntax to
> > > look at.  I should point out that there are also the u,k,h modifiers
> > > which can be specified, even on raw events, so the full syntax looks
> > > something like:
> > > 
> > > -e rXXXX[+YYYY][:u|:k|:h]
> > 
> > Ok I can fix the help text for that.
> 
> If we're frobbing it in the existing config qword, do we still need
> special syntax?

No, it could be all merged then.

> 
> Also, I think we can use the same mechanism to program the
> PEBS-load-latency MSR, right?

I haven't looked at that, but if it's a per core resource
the infrastructure can be reused at least.

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/